Autopilot run: re-review modal Escape + focus (issue #30)¶
Plan: docs/plans/plan-rereview-modal-escape-focus.md (reused, plan approved at Gate 1 by the owner). Commit: c1d2a550.
| Stage | Result |
|---|---|
| Plan / plan review | Reused; plan review approve in round 2 (plan job) |
| Implement | RE-1, RE-2 in SuggestionCard.jsx and its test |
| Regression proof | Without the fix: Escape-closes and focus tests FAIL; with it: PASS. The pending guard test passes either way (a guard, as the plan states) |
| Code review | worker-reviewer, round 1: approve, 0 blocking, 2 advisories |
| QA ×2 | scripts/qa-twice.sh: 13 tests, pass 13, flaky 0, fail 0 |
| Gates | npm run test: 466 passed (54 files). npm run lint: 0 errors, 3 pre-existing warnings in other files. No backend change, so no mvn verify |
Open advisories¶
- No test that a parent re-render leaves focus alone (the reason for the separate focus effect).
- "Listener is gone" is inferred from the dialog staying absent; a
removeEventListenerspy would be direct.
Manual check for the owner¶
Open My suggestions, click "Request re-review": the message field has focus; Escape closes it; with the request in flight Escape does nothing.
Cost¶
See the job cost comments on the PR.